Fix sum by name in custom metrics - #24673
Open
gabotechs wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24673 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 1118 1118
Lines 399602 399638 +36
Branches 399602 399638 +36
=======================================
+ Hits 325458 325505 +47
+ Misses 55146 55136 -10
+ Partials 18998 18997 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nuno-faria
approved these changes
Aug 27, 2026
| self.sum(|m| match m.value() { | ||
| MetricValue::Count { name, .. } => name == metric_name, | ||
| MetricValue::Time { name, .. } => name == metric_name, | ||
| MetricValue::OutputRows(_) => false, |
Contributor
There was a problem hiding this comment.
I wonder if in the future we should also add metrics like OutputRows to this (i.e., metric_name == "output_rows").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Something small I spotted.
MetricValue::sum_by_nameseems to be ignoring custom metrics, while these metrics also have a valid name.What changes are included in this PR?
The fix and one unit test.
Are these changes tested?
Yes
Are there any user-facing changes?
People can now call
sum_by_namein custom metrics